Skip to content

Remove unused methods in DefaultS3CrtClientBuilder #3879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove unused methods in DefaultS3CrtClientBuilder #3879

merged 1 commit into from
Apr 4, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Apr 3, 2023

Motivation and Context

Remove unused methods. Discovered while working on #3829, but pulled into separate PR here.

Modifications

Remove unused methods.

Testing

./mvnw clean install -pl :s3

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner April 3, 2023 19:42
@gosar gosar requested a review from zoewangg April 3, 2023 19:42
@gosar gosar mentioned this pull request Apr 3, 2023
Merged
12 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 32 Code Smells

73.7% 73.7% Coverage
4.2% 4.2% Duplication

@gosar gosar merged commit 365bab1 into feature/master/sra-identity-auth Apr 4, 2023
@gosar gosar deleted the gosar/sra-ia-identity-unused-methods branch April 4, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems approved these changes

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gosar @millems @zoewangg