Add create() for new AwsCredentials Identity types #3884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
For the new AwsCredentials Identity types, provide a
create()
to easily instantiate objects of the new type.Modifications
Add
create()
to the interfaces. Updated other code to use these methods.Note, added them to AwsCredentialsIdentity and AwsSessionCredentialsIdentity separately instead of both methods in AwsCredentialsIdentity as per design doc.
Note, does not allow anonymous credentials with new type. Should it?
Note, these anonymous classes have their equals/hashCode. And
assertThat(AwsBasicCredentials.create("a", "b")).isNotEqualTo(AwsCredentialsIdentity.create("a", "b"));
Note, AwsBasicCredentials.create uses
trimToNull
, but AwsSessionCredentials.create doesn't. Didn't use trimToNull in the new types.Testing
./mvnw clean install -pl :identity-spi,:auth,:s3
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License