Skip to content

Add create() for new AwsCredentials Identity types #3884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Apr 5, 2023

Motivation and Context

For the new AwsCredentials Identity types, provide a create() to easily instantiate objects of the new type.

Modifications

Add create() to the interfaces. Updated other code to use these methods.

Note, added them to AwsCredentialsIdentity and AwsSessionCredentialsIdentity separately instead of both methods in AwsCredentialsIdentity as per design doc.

Note, does not allow anonymous credentials with new type. Should it?

Note, these anonymous classes have their equals/hashCode. And
assertThat(AwsBasicCredentials.create("a", "b")).isNotEqualTo(AwsCredentialsIdentity.create("a", "b"));

Note, AwsBasicCredentials.create uses trimToNull, but AwsSessionCredentials.create doesn't. Didn't use trimToNull in the new types.

Testing

./mvnw clean install -pl :identity-spi,:auth,:s3

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner April 5, 2023 07:58
@gosar gosar requested a review from dagnir April 5, 2023 18:15
Will make it easier to discover `AwsSessionCredentialsIdentity.create` if
looking at `AwsCredentialsIdentity` and wondering how to create a session
credentials.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 33 Code Smells

67.5% 67.5% Coverage
6.1% 6.1% Duplication

@gosar gosar merged commit d41c517 into feature/master/sra-identity-auth Apr 6, 2023
@gosar gosar deleted the gosar/sra-ia-identity-create branch April 6, 2023 18:28
aws-sdk-java-automation pushed a commit that referenced this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants