Accept and use the new TokenIdentity interfaces #3895
Conversation
gosar
force-pushed
the
gosar/sra-ia-identity-token
branch
4 times, most recently
from
4a92a1f to
2e49e90
Compare
gosar
force-pushed
the
gosar/sra-ia-identity-token
branch
from
2e49e90 to
eaf2108
Compare
core/auth/src/main/java/software/amazon/awssdk/auth/token/credentials/TokenUtils.java
Outdated
Show resolved
Hide resolved
gosar
requested review from
cenedhryn and
joviegas
and removed request for
cenedhryn
.../auth/src/main/java/software/amazon/awssdk/auth/token/credentials/SdkTokenProviderChain.java
Show resolved
Hide resolved
core/auth/src/main/java/software/amazon/awssdk/auth/token/credentials/TokenUtils.java
Outdated
Show resolved
Hide resolved
...h/src/test/java/software/amazon/awssdk/auth/token/credentials/SdkTokenProviderChainTest.java
Show resolved
Hide resolved
| static TokenIdentity create(String token) { | ||
| Validate.paramNotNull(token, "token"); | ||
|
|
||
| return new TokenIdentity() { |
There was a problem hiding this comment.
Can you refresh my mind why we're doing the identity as an inline definition? Is it because we already have a token elsewhere?
There was a problem hiding this comment.
Yeah, the token implementations we have are in other modules (sso/ssooidc). For AwsCredentials, there are implementations in the auth module. Used anonymous inner classes here to avoid creating a named classes like AwsCredentialsIdentityImpl or clashing names with AwsBasicCredentials and followed the same approach here. I went off a comment from Matt during the surface area review, but I might have misinterpreted it. LMK if you think this should be organized differently.
There was a problem hiding this comment.
I'd rather not create more classes right now, this seems easier to change if needed so I think we should keep it.
|
SonarCloud Quality Gate failed. |
Motivation and Context
As part of SRA, earlier PR added the new interfaces. This PR updates existing code to accept and use the new Token specific interfaces.
Modifications
This PR updates existing interfaces where customers used to be able to provide SdkTokenProvider, to be able to provide the new interface - IdentityProvider<? extends TokenIdentity> - in service client builders (via codegen), SdkTokenProviderChain.
Testing
Added tests and
./mvnw clean install -pl :auth,:aws-core,:codegen,:codegen-generated-classes-testScreenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License