-
Notifications
You must be signed in to change notification settings - Fork 915
Add adaptive retry strategy #3957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sugmanue
merged 4 commits into
feature/master/sra-retries
from
sugmanue/add-adaptive-retry-strategy
May 5, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
91 changes: 91 additions & 0 deletions
91
core/retries/src/main/java/software/amazon/awssdk/retries/AdaptiveRetryStrategy.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.retries; | ||
|
||
import java.util.function.Predicate; | ||
import software.amazon.awssdk.annotations.SdkPublicApi; | ||
import software.amazon.awssdk.annotations.ThreadSafe; | ||
import software.amazon.awssdk.retries.api.AcquireInitialTokenRequest; | ||
import software.amazon.awssdk.retries.api.BackoffStrategy; | ||
import software.amazon.awssdk.retries.api.RetryStrategy; | ||
import software.amazon.awssdk.retries.internal.AdaptiveRetryStrategyImpl; | ||
import software.amazon.awssdk.retries.internal.circuitbreaker.TokenBucketStore; | ||
import software.amazon.awssdk.retries.internal.ratelimiter.RateLimiterTokenBucketStore; | ||
|
||
/** | ||
* The adaptive retry strategy is a {@link RetryStrategy} when executing against a very resource-constrained set of resources. | ||
* <p> | ||
* Unlike {@link StandardRetryStrategy}, care should be taken when using this strategy. Specifically, it should be used: | ||
* <ol> | ||
* <li>When the availability of downstream resources are mostly affected by callers that are also using | ||
* the {@link AdaptiveRetryStrategy}. | ||
* <li>The scope (either the whole strategy or the {@link AcquireInitialTokenRequest#scope}) of the strategy is constrained | ||
* to target "resource", so that availability issues in one resource cannot delay other, unrelated resource's availability. | ||
* <p> | ||
* The adaptive retry strategy by default: | ||
* <ol> | ||
* <li>Retries on the conditions configured in the {@link Builder}. | ||
* <li>Retries 2 times (3 total attempts). Adjust with {@link Builder#maxAttempts} | ||
* <li>Uses a dynamic backoff delay based on load currently perceived against the downstream resource | ||
* <li>Circuit breaking (disabling retries) in the event of high downstream failures within an individual scope. | ||
* Circuit breaking may prevent a first attempt in outage scenarios to protect the downstream service. | ||
* </ol> | ||
* | ||
* @see StandardRetryStrategy | ||
*/ | ||
@SdkPublicApi | ||
@ThreadSafe | ||
public interface AdaptiveRetryStrategy extends RetryStrategy<AdaptiveRetryStrategy.Builder, AdaptiveRetryStrategy> { | ||
|
||
/** | ||
* Create a new {@link AdaptiveRetryStrategy.Builder}. | ||
* | ||
* <p>Example Usage | ||
* <pre> | ||
* AdaptiveRetryStrategy retryStrategy = | ||
* AdaptiveRetryStrategy.builder() | ||
* .retryOnExceptionInstanceOf(IllegalArgumentException.class) | ||
* .retryOnExceptionInstanceOf(IllegalStateException.class) | ||
* .build(); | ||
* </pre> | ||
*/ | ||
static AdaptiveRetryStrategy.Builder builder() { | ||
return AdaptiveRetryStrategyImpl | ||
.builder() | ||
.maxAttempts(DefaultRetryStrategy.Standard.MAX_ATTEMPTS) | ||
.tokenBucketStore(TokenBucketStore.builder() | ||
.tokenBucketMaxCapacity(DefaultRetryStrategy.Standard.TOKEN_BUCKET_SIZE) | ||
.build()) | ||
.tokenBucketExceptionCost(DefaultRetryStrategy.Standard.TOKEN_BUCKET_SIZE) | ||
.backoffStrategy(BackoffStrategy.exponentialDelay(DefaultRetryStrategy.Standard.BASE_DELAY, | ||
DefaultRetryStrategy.Standard.MAX_BACKOFF)) | ||
.rateLimiterTokenBucketStore(RateLimiterTokenBucketStore.builder().build()); | ||
} | ||
|
||
@Override | ||
Builder toBuilder(); | ||
|
||
interface Builder extends RetryStrategy.Builder<Builder, AdaptiveRetryStrategy> { | ||
/** | ||
* Configure the predicate to allow the strategy categorize a Throwable as throttling exception. | ||
*/ | ||
Builder treatAsThrottling(Predicate<Throwable> treatAsThrottling); | ||
|
||
|
||
@Override | ||
AdaptiveRetryStrategy build(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.