Skip to content

Add new Signer interfaces #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2023

Conversation

gosar
Copy link
Contributor

@gosar gosar commented May 2, 2023

Motivation and Context

As part of Smithy Reference Architecture, we are defining new Identity and Auth components. This changes adds the new Signer interfaces.

Modifications

This changes adds the new Signer interfaces in the http-auth-spi module.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar marked this pull request as ready for review May 3, 2023 04:17
@gosar gosar requested a review from a team as a code owner May 3, 2023 04:17
@gosar gosar requested a review from zoewangg May 3, 2023 04:18
@gosar gosar force-pushed the gosar/sra-ia-signer-spi branch from cc153f1 to 03c6d9c Compare May 3, 2023 18:33
@gosar gosar requested a review from zoewangg May 10, 2023 17:20
@gosar gosar mentioned this pull request May 10, 2023
12 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 73 Code Smells

49.8% 49.8% Coverage
3.7% 3.7% Duplication

@gosar gosar merged commit 3d24f09 into feature/master/sra-identity-auth May 10, 2023
@gosar gosar deleted the gosar/sra-ia-signer-spi branch May 10, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants