Use mock HTTP clients in timeout tests #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any data on how reliable the mock clients are compared to wiremock, ie did you do any repeated tests before/after the code change and could see a measurable difference? |
cenedhryn
reviewed
May 9, 2023
...c/test/java/software/amazon/awssdk/protocol/tests/timeout/BaseApiCallAttemptTimeoutTest.java
Show resolved
Hide resolved
From my observation, wiremock severs sometimes don't honor the configured fixed delay, i.e., it would return the response much later after the configured delay. Mock HTTP clients are written by us, so it's guaranteed it'll return after the configured delay. The tests are only flaky in CodeBuild environments, so I'm not able to compare them locally. |
cenedhryn
reviewed
May 9, 2023
...ocol-tests/src/test/java/software/amazon/awssdk/protocol/tests/util/MockAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
May 9, 2023
...t-utils/src/main/java/software/amazon/awssdk/testutils/service/http/MockAsyncHttpClient.java
Show resolved
Hide resolved
cenedhryn
reviewed
May 9, 2023
...t-utils/src/main/java/software/amazon/awssdk/testutils/service/http/MockAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
May 9, 2023
...c/test/java/software/amazon/awssdk/protocol/tests/timeout/BaseApiCallAttemptTimeoutTest.java
Outdated
Show resolved
Hide resolved
cenedhryn
approved these changes
May 9, 2023
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Wiremock is not reliable in timeout tests
Modifications
Use mock HTTP clients in timeout tests