Skip to content

Add default bearer signer and stubs for other signers #4003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

haydenbaker
Copy link
Contributor

@haydenbaker haydenbaker commented May 12, 2023

Motivation and Context

  • See below

Modifications

  • Add a default implementation of the BearerHttpSigner and tests
  • Add stubs for all signer default implementations
  • Fix up signer interface definitions to include identity (needed after update to HttpSigner interface)
  • Fix up POMs to address some small nits

Testing

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-signer-interfaces branch from 05b604b to 158c894 Compare May 15, 2023 15:28
@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-signer-interfaces branch from a18e871 to 988812f Compare May 24, 2023 22:40
@haydenbaker haydenbaker changed the title Add initial default bearer signer, Fix HttpSign* interfaces Add initial default bearer signer and stubs for other signers May 24, 2023
@haydenbaker haydenbaker changed the title Add initial default bearer signer and stubs for other signers Add default bearer signer and stubs for other signers May 24, 2023
@haydenbaker haydenbaker marked this pull request as ready for review May 24, 2023 22:53
@haydenbaker haydenbaker requested a review from a team as a code owner May 24, 2023 22:53
@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-signer-interfaces branch from 988812f to 6bed7ec Compare May 25, 2023 15:30
@haydenbaker haydenbaker requested a review from davidh44 May 25, 2023 15:33
@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-signer-interfaces branch 2 times, most recently from ce8f362 to c48dbe5 Compare May 25, 2023 16:53
@haydenbaker haydenbaker force-pushed the haydenbaker/sra-ia-signer-interfaces branch from c48dbe5 to 8db9879 Compare May 25, 2023 16:57
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 122 Code Smells

61.5% 61.5% Coverage
1.1% 1.1% Duplication

@gosar gosar merged commit b6382c5 into feature/master/sra-identity-auth May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants