HttpSigner interface changes

[gosar]

Motivation and Context

Modifications

Option to add Identity to the interface:

• Make Identity explicit parameter in HttpSigner

Compare with option in #4018

Also,

• Remove wildcards from sign methods

Other fixes:

• Remove for HttpAuthOption.Builder.schemeId
• Fix generics related warning in Signer interfaces

Usage for this option would look like:

HttpSigner<TokenIdentity> signer = new HttpSigner<TokenIdentity>() {
    @Override
    public SignedHttpRequest<ContentStreamProvider> sign(TokenIdentity identity,
                                                         HttpSignRequest<ContentStreamProvider> request) {
        // Do stuff while using
        // property = request.property(SignerProperty.create(String.class, "key"));
        // identity;
        return null;
    }

    @Override
    public SignedHttpRequest<Publisher<ByteBuffer>> signAsync(TokenIdentity identity, HttpSignRequest<Publisher<ByteBuffer>> request) {
        return null;
    }
};

TokenIdentity identity = TokenIdentity.create("token");
HttpSignRequest<ContentStreamProvider> request = HttpSignRequest
    .builder(ContentStreamProvider.class)
    .putProperty(SignerProperty.create(String.class, "key"), "value")
    .build();
signer.sign(identity, request);

Testing

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

SonarCloud Quality Gate failed.   

3 Bugs
0 Vulnerabilities
0 Security Hotspots
75 Code Smells

46.6% Coverage
3.0% Duplication

[gosar]

Between this PR and #4018, we decided to go with approach in #4018 so closing this PR.