Refactors credential identity with separate implementing classes #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
reviewed
May 18, 2023
| .add("accessKeyId", accessKeyId) | ||
| .build(); | ||
| } | ||
| interface Builder { |
There was a problem hiding this comment.
I didn't think it was necessarily needed, but we can add it.
There was a problem hiding this comment.
I played around with different versions of CopyableBuilder, but it doesn't work for the subtypes. If AwsCredentialsIdentity implements ToCopyableBuilder the returned builder will be of type AwsCredentialsIdentity.Builder for AwsSessionCredentialsIdentity too and you'll lose the specific information in the subtype.
|
|
||
| @Override | ||
| public String toString() { | ||
| return ToString.builder("AwsCredentialsIdentity") |
There was a problem hiding this comment.
AwsSessionCredentialsIdentity?
gosar
approved these changes
May 18, 2023
gosar
reviewed
May 19, 2023
| return hashCode; | ||
| } | ||
|
|
||
| static final class Builder implements AwsCredentialsIdentity.Builder { |
There was a problem hiding this comment.
seems like these could be private?
There was a problem hiding this comment.
yes, that'd be better
millems
approved these changes
May 19, 2023
|
SonarCloud Quality Gate failed.
|
cenedhryn
added a commit
that referenced
this pull request
May 23, 2023
…) (#4028) * refactors credential identity to create separate classes
12 tasks
cenedhryn
added a commit
that referenced
this pull request
Apr 17, 2024
…) (#4028) * refactors credential identity to create separate classes
cenedhryn
added a commit
that referenced
this pull request
Apr 22, 2024
…5119) * Adds account ID as a built-in endpoint parameter (#4016) * Refactors credential identity with separate implementing classes (#4024) (#4028) * Adds accountId as a parameter to AWS credentials identity (#4029) * Adds accountId to STS credentials providers (#4040) * Adding accountId support to environment variable credential provider (#4327) * Adds accountId support to process credentials provider (#4332) * Adds account ID support for profile credentials provider sources (#4340) * Adds accountId endpoint mode (#4984) * Adding back existing endpoint files (#5120) * changelog (#5121)
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
…ws#5119) * Adds account ID as a built-in endpoint parameter (aws#4016) * Refactors credential identity with separate implementing classes (aws#4024) (aws#4028) * Adds accountId as a parameter to AWS credentials identity (aws#4029) * Adds accountId to STS credentials providers (aws#4040) * Adding accountId support to environment variable credential provider (aws#4327) * Adds accountId support to process credentials provider (aws#4332) * Adds account ID support for profile credentials provider sources (aws#4340) * Adds accountId endpoint mode (aws#4984) * Adding back existing endpoint files (aws#5120) * changelog (aws#5121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The new
AwsCredentialsIdentityandAwsSessionCredentialsIdentityinterfaces have inline classes that implement the interface. This PR extracts these inline classes and adds builder support for the identity interfaces in order to support future additional parameters.