Fix bug about wrong part size number in CopyObjectHelper #4049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
approved these changes
May 29, 2023
| @@ -130,7 +130,7 @@ private void doCopyInParts(CopyObjectRequest copyObjectRequest, | |||
| Long contentLength, | |||
| CompletableFuture<CopyObjectResponse> returnFuture, | |||
| String uploadId) { | |||
| long optimalPartSize = calculateOptimalPartSizeForCopy(partSizeInBytes); | |||
| long optimalPartSize = calculateOptimalPartSizeForCopy(contentLength); | |||
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
CopyObjectHelperthe methodcalculateOptimalPartSizeForCopy(long contentLengthOfSource)expect the content length of the whole object to copy, but is passed the part size instead. This PR is to fix that issue, now it is passed the content length so that the part size can be automatically adjusted if the total number of parts would exceed 10,000.