Updates StsCredentialsProvider to explicitly handle AwsSessionCredentials #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenedhryn
changed the title
millems
reviewed
Jun 7, 2023
| "type": "feature", | ||
| "category": "AWS SDK for Java v2, AWS STS", | ||
| "contributor": "", | ||
| "description": "Updates the core STS credential provider logic to return AwsSessionCredentials instead of STS Credentials, and adds expirationTime to AwsSessionCredentials\"" |
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "type": "feature", | |||
| "category": "AWS SDK for Java v2, AWS STS", | |||
There was a problem hiding this comment.
Maybe we just document the addition of expirationTime to AwsSessionCredentials? The other one is hopefully internal-only(ish). Otherwise I think we should have two different release notes...
There was a problem hiding this comment.
Makes sense, will update
| return this; | ||
| } | ||
|
|
||
| public Builder expiration(Instant expiration) { |
| return hashCode; | ||
| } | ||
|
|
||
| public static final class Builder { |
gosar
reviewed
Jun 7, 2023
| private StsAuthUtils() { | ||
| } | ||
|
|
||
| public static AwsSessionCredentials fromStsCredentials(Credentials credentials) { |
There was a problem hiding this comment.
nit: I think toAwsSessionCredentials might be a better name. The "from" type is evident by the method parameter. The "to" type is more useful in the method name.
There was a problem hiding this comment.
agree, it read better
|
Kudos, SonarCloud Quality Gate passed! |
millems
approved these changes
Jun 8, 2023
L-Applin
pushed a commit
that referenced
this pull request
Jul 24, 2023
…ials (#4067) * Updates StsCredentialsProvider to explicitly handle AwsSessionCredentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The abstract base class for STS credentials provider was recently made public. This change changes the protected
getUpdatedCredentialsmethod to returnAwsSessionCredentials, a public class, instead of instead of the STS model classCredentials, so that the SDK handles and stores credentials in a type which may be modified by the SDK. The change is not strictly backwards compatible, but given the short timespan between the two PRs it's unlikely that more than the occasional user would be affected.Modifications
getUpdatedCredentialsmethod to returnAwsSessionCredentialsinstead of the STS model classCredentials.StsCredentialsProvider.expirationTimetoAwsSessionCredentialsin order to convert STS credentials to session credentials. Previously, expiration has been stored outside of the session credentialsSessionCredentialsHolderwhich has been rendered obsolete by this changeTesting
Unit tests added.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License