Update window using correct remaining() value #4184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the receive window for the CRT client is updated with the value of remaining() *after* it's been read, which is incorrect as this will be 0 if the buffer has been fully consumed, which is it should be.
millems
approved these changes
Jul 13, 2023
zoewangg
approved these changes
Jul 13, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
As it was a bug, shouldn't the fix be accompanied with a respective unit/integration test? |
L-Applin
pushed a commit
that referenced
this pull request
Jul 24, 2023
This commit fixes an issue where the receive window for the CRT client is updated with the value of remaining() *after* it's been read, which is incorrect as this will be 0 if the buffer has been fully consumed, which is it should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the receive window for the CRT client is updated with the value of remaining() after it's been read, which is incorrect as this will be 0 if the buffer has been fully consumed, which is it should be.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License