Fix to handle temporary Redirect 307 for S3 Cross Region client #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Jul 18, 2023
|
|
||
| public class S3CrossRegionCrtIntegrationTest extends S3CrossRegionAsyncIntegrationTestBase { | ||
| private static final String BUCKET = temporaryBucketName(S3CrossRegionCrtIntegrationTest.class); | ||
|
|
||
| @BeforeAll | ||
| static void setUpClass() { | ||
| s3 = s3ClientBuilder().build(); | ||
| s3 = s3ClientBuilder().region(Region.AP_SOUTH_1).httpClient(ApacheHttpClient.create()).build(); |
There was a problem hiding this comment.
Question: why do we need to set ApacheHttpClient explicitly? If we have to, can we use httpClientBuilder(ApacheHttpClient.builder()) so that the http client can be closed?
There was a problem hiding this comment.
Added by mistake just for testing , removed it now
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "type": "bugfix", | |||
| "category": "AWS SDK for Java v2", | |||
There was a problem hiding this comment.
nit: category should be S3
zoewangg
approved these changes
Jul 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
License