Skip to content

Fix flaky test: SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix flaky test: SimplePublisherTest#stochastic_onNext_multiProducerSeemsThreadSafe #4206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions utils/src/test/java/software/amazon/awssdk/utils/async/SimplePublisherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ private void seemsThreadSafeWithProducerCount(int producerCount) {
AtomicLong messageSendCount = new AtomicLong(0);
AtomicLong messageReceiveCount = new AtomicLong(0);

CountDownLatch producersDone = new CountDownLatch(producerCount);
Semaphore productionLimiter = new Semaphore(101);
Semaphore requestLimiter = new Semaphore(57);
ExecutorService executor = Executors.newFixedThreadPool(2 + producerCount);
Expand All @@ -431,6 +432,10 @@ private void seemsThreadSafeWithProducerCount(int producerCount) {
productionLimiter.acquire();
publisher.send(messageSendCount.getAndIncrement());
}

// Complete once all producers are done
producersDone.countDown();
producersDone.await();
publisher.complete().thenRun(() -> completed.complete(null)); // All but one producer sending this will fail.
return null;
}));
Expand Down