Enable UrlConnection http client chunked encoding #4207

davidh44 · 2023-07-18T23:46:34Z

Motivation and Context

Enable chunked encoding in URLConnection HTTP Client.
setRequestProperty("Transfer-Encoding", "chunked") does not have any effect

Modifications

setChunkedStreamingMode(-1) when Transfer-Encoding:chunked is present, which will prompt HttpURLConnection to use the default chunklen value and enable chunked encoding

Testing

To uncomment integ test from Apache fix PR once merged

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have read the CONTRIBUTING document
Local run of mvn install succeeds
My code follows the code style of this project
My change requires a change to the Javadoc documentation
I have updated the Javadoc documentation accordingly
I have added tests to cover my changes
All new and existing tests passed
I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

I confirm that this pull request can be released under the Apache 2 license

millems · 2023-07-19T17:59:50Z

...test/java/software/amazon/awssdk/http/urlconnection/UrlConnectionHttpClientWireMockTest.java

+                                                                          .build())
+                                        .call();
+
+        mockServer.verify(postRequestedFor(urlPathEqualTo("/")).withHeader(TRANSFER_ENCODING, equalTo(CHUNKED)));
