Copy SSE-C parameters when performing multipart copy #4219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the SSE-C parameters are not copied to the CompleteMultipartUpload request when transforming to a multipart copy.
millems
reviewed
Jul 20, 2023
Comment on lines
+192
to
+194
| .sseCustomerAlgorithm(copyObjectRequest.sseCustomerAlgorithm()) | ||
| .sseCustomerKey(copyObjectRequest.sseCustomerKey()) | ||
| .sseCustomerKeyMD5(copyObjectRequest.sseCustomerKeyMD5()) |
There was a problem hiding this comment.
Doesn't seem scalable. Is there a way to copy fields by name or something using SdkFields?
There was a problem hiding this comment.
Yeah, this was already done in #4177. We can switch to that once it gets merged to mainline
millems
approved these changes
Jul 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This commit fixes a bug where the SSE-C parameters are not copied to the CompleteMultipartUpload request when transforming to a multipart copy.
Modifications
Testing
Added new unit test.
One off testing with S3.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License