S3 Multipart API implementation

[L-Applin]

Adds MultipartConfiguration to the S3AsyncClientBuilder to enables Multipart operation on S3AsyncClient.

The following methods were added to S3AsyncClientBuilder (codegen):

    /**
     * Configuration for multipart operation of this client. Calling this method with a non null argument will enable
     * automatic conversion of Get, Put and Copy requests to their multipart equivalent.
     */
    default S3AsyncClientBuilder multipartConfiguration(MultipartConfiguration multipartConfiguration) {
        throw new UnsupportedOperationException();
    }

    /**
     * Configuration for multipart operation of this client. Calling this method with a non null argument will enable
     * automatic conversion of Get, Put and Copy requests to their multipart equivalent.
     */
    default S3AsyncClientBuilder multipartConfiguration(Consumer<Builder> multipartConfiguration) {
        Builder builder = MultipartConfiguration.builder();
        multipartConfiguration.accept(builder);
        return multipartConfiguration(builder.build());
    }

The following method has been added to DefaultS3AsyncClientBuilder (codegen):

    @Override
    public DefaultS3AsyncClientBuilder multipartConfiguration(MultipartConfiguration multipartConfig) {
        clientContextParams.put(MultipartConfiguration.MULTIPART_CONFIGURATION_KEY, multipartConfig);
        return this;
    }

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
30 Code Smells

83.1% Coverage
0.0% Duplication

[millems]

Why is this in this PR?

[L-Applin]

had to merge master branch to get ClientComposer/DelegateClient related classes

[millems]

What are the pros/cons of this compared to just using customClientContextParams or something similar? https://github.com/aws/aws-sdk-java-v2/blob/master/services/s3/src/main/resources/codegen-resources/customization.config#L255-L260

[L-Applin]

I tried that first, but a custom client context param also adds the method to the sync client builder, but we only want multipart for the async builder. Maybe I am unaware of a way to limit customClientContextParams to only only the sync/async interface?

[millems]

Seems fine, since this is just an internal API. We can always refactor it later if we wanted to. E.g. make customClientContextParams have an async-only flag.

[millems]

Info is a pretty loud log level. Is this necessary?

[L-Applin]

This is only happens when total size / part size > 10,000 which will result in not using the configured part size set by the user (to not hit the 10,000 part limit imposed by s3), I thought being a little loud about it was a good idea.

[millems]

Should we have a flag that the user opts-in to allow this to happen, so that we don't have to warn when it does? (They've consented to it, after all!)

Logging above debug for anything that isn't an error scares me, since we don't know what the user's throughput is like, and we frequently get people upset about us filling their logs.

[L-Applin]

I see, I will lower to debug then, dont want customers to be mad at us 😅

[millems]

Same here

[L-Applin]

see other comment