Introduce the possibility to specify returnValuesOnConditionCheckFailure in DynamoDB Enhanced operations #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e related changes (aws#4442)
|
@breader124 thank you for the PR, this is a highly requested feature, we'll review it as soon as we can. |
…onCheckFailure-to-dynamodb-enhanced
|
SonarCloud Quality Gate failed.
|
|
AWS-SDK build for JDK-21 does not show up on PR, but succeeds |
|
Failed checks belong to incorrectly triggered codebuilds. All checks pass, verified in codebuild |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change is required, because DynamoDB Enhanced library doesn't support returnValuesOnConditionCheckFailure parameter introduced recently in this announcement. Originally the request to introduce changes was reported in scope of #4442
Modifications
In order to add the possibility to specify returnValuesOnConditionCheckFailure and handle it properly I've modified (Put|Update|Delete)ItemEnhancedRequest and (Put|Update|Delete)ItemOperation classes. Then I've modified unit test classes associated with the ones mentioned above. At the very end I've modified both
CrudWithResponseIntegrationTestandAsyncCrudWithResponseIntegrationTestto cover introduced changes with integration tests.Testing
I've implemented both unit and integration tests executed against real DynamoDB table to cover the changes. All tests passed locally.
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License