fix ClientOverrideConfiguration.Builder empty headers throwing NPE #4726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interException if empty
millems
approved these changes
Nov 30, 2023
sugmanue
reviewed
Nov 30, 2023
...ore/src/main/java/software/amazon/awssdk/core/client/config/ClientOverrideConfiguration.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/core/client/config/ClientOverrideConfigurationTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/software/amazon/awssdk/core/client/config/ClientOverrideConfigurationTest.java
Outdated
Show resolved
Hide resolved
…/config/ClientOverrideConfiguration.java Co-authored-by: Manuel Sugawara <[email protected]>
…rtions more obvious
sugmanue
approved these changes
Nov 30, 2023
utils/src/main/java/software/amazon/awssdk/utils/UnmodifiableMapOfLists.java
Outdated
Show resolved
Hide resolved
…apOfLists.java Co-authored-by: Manuel Sugawara <[email protected]>
…into olapplin/override-conf-npe-fix
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
headers()method returns an unmodifiableMapOfLists which assumes the map it delegates to is not null. Butconfig.option(ADDITIONAL_HTTP_HEADERS)returns null if the config is not set.