Fix for Signing Error when ampersand character included in HttpQuery when using DefaultAwsCrtV4aSigner

[joviegas]

Motivation and Context

• Signing Error when ampersand character included in HttpQuery when using DefaultAwsCrtV4aSigner
• If the Query parameters had & in its value then Signing for those request used to always fail.

Modifications

• The crtRequestToHttp loops through query returned by fullUri using "&" and "=" for finding Key and Value.
• When the value has "&" or "=" it assumes it as separate parameters thus we need to use Raw non-decoded parameters,
• The looping is done on getRawQuery and then its Decoded while doing a appendRawQueryParameter

Testing

• Added Junit test case.
• tested with a service where the issue was seen.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

nit: "ampersand"

[dagnir]

Can you add a test that includes other values besides = and & that should be URL encoded? Like a newline or something? Just to make sure CRT handles those too

[joviegas]

done

[sonarqubecloud]

Quality Gate failed

Failed conditions

75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud