Add config class for SplittingTransformer #4939
Conversation
| } | ||
|
|
||
| /** | ||
| * Create a {@link FileRequestBodyConfiguration.Builder}, used to create a {@link SplitTransformerConfiguration}. |
There was a problem hiding this comment.
Why does this mention FileRequestBodyConfiguration?
There was a problem hiding this comment.
oops missed deleting that
| /** | ||
| * Configuration options for {@link AsyncResponseTransformer#split(SplitTransformerConfiguration)} to configure how the SDK | ||
| * should split the {@link AsyncResponseTransformer}. | ||
| * |
There was a problem hiding this comment.
This description makes me think the name is not quite right. "to configure how the SDK should split..." sounds like it's configuration for the splitting transformer (the one we're calling split on), but the name makes it sound like it's for the SplitAsyncResponseTransformer, which is the result of the split.
@zoewangg WDYT?
There was a problem hiding this comment.
right, its used to instantiate a SplittingTransformer which is then passed to the SplitAsyncResponseTransformer
SplittingTransformerConfiguration?
There was a problem hiding this comment.
Okay thanks for clarifying. In that case then yeah I vote for SplittingTransformerConfiguration
|
Motivation and Context
Modifications
Add
SplitTransformerConfigurationfor when callingAsyncResponseTransformer.split()Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License