Skip to content

Surface area review #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 29, 2024
Merged

Surface area review #4971

merged 10 commits into from
Feb 29, 2024

Conversation

L-Applin
Copy link
Contributor

Surface Area Review Changes

  • Remove SplitAsyncResponseTransformer, replacing it with AsyncRersponseTransformer.SplitResult inner interface with default internal implementation, with builder.
  • renamed returnFuture to resultFuture.
  • check and guard against for negative buffer size, renamed to bufferSizeInBytes.
  • add logic to not perform multipart if part number or range is specified.
  • return response from first call to get-object.

Other changes

  • Small refactoring: moved some logic into DownloadObjectHelper to be consistent with upload/copy.

@L-Applin
changelog
7df3c67
@L-Applin
Surface are review comments
4ac4f04 
- Guard for negative buffe size
- interface for SplitAsyncResponseTransformer
- do single part if byte range of part number is specified
@L-Applin
chekstyle + spotbug
d2e1c74
@L-Applin
remove SplitAsyncResponseTransformer, moving it to AsyncResponseTrans…
cde5eb9 
…former.SplitResult. Small refactor, moving some logic to DownloadObjectHelper
@L-Applin
remove bad changelog entry
73eb14c
@L-Applin L-Applin requested a review from a team as a code owner February 27, 2024 17:16
@L-Applin L-Applin requested a review from anirudh9391 February 27, 2024 20:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.7% Coverage on New Code (required ≥ 80%)
4.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

anirudh9391
anirudh9391 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@anirudh9391 anirudh9391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving

@L-Applin L-Applin merged commit a98af91 into feature/master/s3mpu Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirudh9391 anirudh9391 anirudh9391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Applin @anirudh9391