Renamed S3AdvancedConfiguration to S3Configuration and AdvancedServiceConfiguration to ServiceConfiguration.
#502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
May 25, 2018
| @@ -33,8 +33,8 @@ | |||
| /** | |||
| * Handler context key for advanced configuration. | |||
| */ | |||
| public static final ExecutionAttribute<ServiceAdvancedConfiguration> SERVICE_ADVANCED_CONFIG = | |||
| new ExecutionAttribute<>("ServiceAdvancedConfig"); | |||
| public static final ExecutionAttribute<ServiceConfiguration> SERVICE_ADVANCED_CONFIG = | |||
| public static final ExecutionAttribute<ServiceAdvancedConfiguration> SERVICE_ADVANCED_CONFIG = | ||
| new ExecutionAttribute<>("ServiceAdvancedConfig"); | ||
| public static final ExecutionAttribute<ServiceConfiguration> SERVICE_ADVANCED_CONFIG = | ||
| new ExecutionAttribute<>("ServiceServiceConfig"); |
millems
force-pushed
the
millem/service-config-rename
branch
2 times, most recently
from
88f61f4 to
6fad6b6
Compare
|
Verified that the integration tests succeed. |
millems
force-pushed
the
millem/service-config-rename
branch
from
6fad6b6 to
dbdcdbb
Compare
zoewangg
reviewed
May 25, 2018
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "category": "AWS SDK for Java v2", | |||
There was a problem hiding this comment.
nit, category should be Amazon S3 maybe?
zoewangg
approved these changes
May 25, 2018
…dConfiguration to ServiceConfiguration.
millems
force-pushed
the
millem/service-config-rename
branch
from
dbdcdbb to
204a2e2
Compare
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
May 15, 2019
Revert "Standardize buildspec hacks around disabling maven connection pooling."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.