Skip to content

Enable TCP keep alive for CRT HTTP client if configured #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

eckardnet
Copy link
Contributor

Motivation and Context

I configured keep alive for http crt client, but it din't seem to have an effect.
I did not find a way to set this boolean to true in SocketOptions in any other way.

Modifications

Set boolean to true if keep alive config is not null.

Testing

no testing

Screenshots (if appropriate)

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [x ] I confirm that this pull request can be released under the Apache 2 license

@eckardnet eckardnet requested a review from a team as a code owner March 27, 2024 16:54
@zoewangg
Copy link
Contributor

zoewangg commented Mar 27, 2024

This seems like a regression on CRT side introduced in awslabs/aws-crt-java#750. Setting it to true was not required before. (Edit: nvm, I misspoke)

@eckardnet eckardnet requested a review from zoewangg March 29, 2024 12:25
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. LGTM, triggering builds

@zoewangg zoewangg enabled auto-merge (squash) April 9, 2024 23:16
@eckardnet
Copy link
Contributor Author

Do I have to do anything more now?

Copy link

@zoewangg zoewangg merged commit a4c7bb4 into aws:master Apr 10, 2024
@zoewangg
Copy link
Contributor

@all-contributors please add @eckardnet for code

Copy link
Contributor

@zoewangg

I've put up a pull request to add @eckardnet! 🎉

@eckardnet
Copy link
Contributor Author

Thank you :-)

akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
* enable keep alive if configured

* Added test.

* Added changelog.

---------

Co-authored-by: Eckard Mühlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants