-
Notifications
You must be signed in to change notification settings - Fork 916
Enable TCP keep alive for CRT HTTP client if configured #5052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
...-client/src/main/java/software/amazon/awssdk/http/crt/internal/AwsCrtConfigurationUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay. LGTM, triggering builds
Do I have to do anything more now? |
|
@all-contributors please add @eckardnet for code |
I've put up a pull request to add @eckardnet! 🎉 |
Thank you :-) |
* enable keep alive if configured * Added test. * Added changelog. --------- Co-authored-by: Eckard Mühlich <[email protected]>
Motivation and Context
I configured keep alive for http crt client, but it din't seem to have an effect.
I did not find a way to set this boolean to true in SocketOptions in any other way.
Modifications
Set boolean to true if keep alive config is not null.
Testing
no testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License