Fix for threads hanging with forwardTransformedResultTo #5117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
CompletableFutureUtils.forwardTransformedResultTo
if the provided function throws an exception, it would not be catch which can prevent the destination future to be completed and hang on a.join()
call.Motivation and Context
Discovered during perf testing multipart s3 async client, as one of the test returned a null value.
Modifications
Surround the call to
Function.apply()
with a try-catch and complete the destination future with the caught exception.Testing
Added unit test to CompletableUtils and TransferManager