Skip to content

Fix stability tests #5178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented May 3, 2024

Motivation and Context

Fix stability tests

  • increase allowed thread threshold: S3 multipart client uses more threads because for large file uploads, it reads from different positions of the files at the same time, which will trigger more Java I/O threads to spin up
  • not fail stability tests based on thread count because if one test has increased thread count, it'd affect other tests, which will make the assertion more or less useless.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner May 3, 2024 02:42
@zoewangg zoewangg force-pushed the zoewang/fixStabilityTests branch from ae45181 to f608808 Compare May 3, 2024 03:09
@zoewangg zoewangg force-pushed the zoewang/fixStabilityTests branch from f608808 to 1089240 Compare May 3, 2024 03:48
Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zoewangg zoewangg merged commit 405cc74 into feature/master/s3mpu May 3, 2024
@zoewangg zoewangg deleted the zoewang/fixStabilityTests branch May 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants