Enforce that enum names must be singular, not plural. #520
Conversation
| } | ||
|
|
||
| private boolean isPlural(String className) { | ||
| return DISALLOWED_ENDINGS.stream().anyMatch(className::endsWith) && |
There was a problem hiding this comment.
It's kind of confusing to name them allowed/disallowed since it depends more on the context in which they are used whether they are allowed or not. Perhaps just PLURAL_ENDINGS and NON_PLURAL_ENDINGS or something along those lines?
| } | ||
|
|
||
| private boolean isPluralDisallowed(DetailAST ast) { | ||
| return !isEnum(ast) && !hasPublicStaticField(ast); |
There was a problem hiding this comment.
Is this right? It seems backwards to me but perhaps my brain is at reduced capacity right now.
There was a problem hiding this comment.
Yeah, I changed it elsewhere and forgot to change it here. Good catch.
| @@ -28,15 +28,15 @@ | |||
|
|
|||
| public final class DocumentationUtils { | |||
|
|
|||
| public static final String DEFAULT_SETTER = "Sets the value of the %s property for this object."; | |||
| private static final String DEFAULT_SETTER = "Sets the value of the %s property for this object."; | |||
There was a problem hiding this comment.
Hmm this feels like cheating... ;)
| @@ -24,7 +24,7 @@ | |||
| import software.amazon.awssdk.utils.http.SdkHttpUtils; | |||
|
|
|||
| @SdkProtectedApi | |||
| public final class PathMarshallers { | |||
| public abstract class PathMarshaller { | |||
There was a problem hiding this comment.
Can this still be an interface? Or does it have something to do with the private static classes?
There was a problem hiding this comment.
Nothing can be private in an interface (before Java 9).
| */ | ||
| public enum KnownJavaVersions { | ||
| public enum KnownJavaVersion { |
There was a problem hiding this comment.
This probably needs to go. Can you add a review before release?
| @@ -22,7 +22,7 @@ | |||
| * Default configuration values. | |||
| */ | |||
| @ReviewBeforeRelease("These values") | |||
| public final class Defaults { | |||
| public final class Default { | |||
There was a problem hiding this comment.
Maybe rename to DefaultConfiguration or DefaultSetting
millems
force-pushed
the
millem/singular-enums
branch
3 times, most recently
from
842bc8f to
b63ea14
Compare
millems
force-pushed
the
millem/singular-enums
branch
from
b63ea14 to
cd06399
Compare
…e6f1604b Pull request: release <- staging/42a93eca-9b2f-49b8-a049-4ad6e6f1604b
Reviewer notes: New checkstyle rule implemented in "PluralEnumNames.java". This does not apply to modeled objects.