Verifying the http default values #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunnvs92
force-pushed
the
varunkn/CleanupTasks2
branch
from
3172214 to
88c86de
Compare
varunnvs92
force-pushed
the
varunkn/CleanupTasks2
branch
from
88c86de to
bd48f53
Compare
spfink
approved these changes
Jun 6, 2018
| * Whether the default configuration applied to AWS clients should be optimized for services within the same region. | ||
| * This will usually include lower request timeouts because requests do not need to travel outside of the AWS network. | ||
| */ | ||
| AWS_IN_REGION_OPTIMIZATION_ENABLED("aws.inRegionOptimizationEnabled", "false"), |
There was a problem hiding this comment.
Are we removing this because it is unused?
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 5, 2019
…fbb0f478 Pull request: release <- staging/1a31d288-677e-4b7d-a59b-1706fbb0f478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All current options in following classes are advanced
AwsAdvancedClientOption
SdkAdvancedClientOption
SdkAdvancedAsyncClientOption
All default values match the values used in v1. I don't remember any discussion on changing these values.
https://github.com/aws/aws-sdk-java-v2/blob/master/http-client-spi/src/main/java/software/amazon/awssdk/http/SdkHttpConfigurationOption.java#L81-L88
https://github.com/aws/aws-sdk-java-v2/blob/master/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/Defaults.java
Other Changes
Removed unused option in SdkSystemSetting class