add completed to ResumableFileDownload ser/des #5254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ResumableFileDownloadSerializerTest
davidh44
approved these changes
May 29, 2024
zoewangg
reviewed
May 30, 2024
| * @return part numbers of a multipart download that were completed saved to file. | ||
| */ | ||
| public List<Integer> completedParts() { | ||
| return Collections.unmodifiableList(completedParts); |
There was a problem hiding this comment.
Can we wrap with umodifableList in the ctor instead of the getter? Also, we should probably create a new list. Example: https://github.com/aws/aws-sdk-java-v2/blob/master/core/sdk-core/src/main/java/software/amazon/awssdk/core/client/config/ClientOverrideConfiguration.java#L148
There was a problem hiding this comment.
will address in full resume PR
| @@ -61,6 +63,7 @@ public final class ResumableFileDownload implements ResumableTransfer, | |||
| private final Instant s3ObjectLastModified; | |||
| private final Long totalSizeInBytes; | |||
| private final Instant fileLastModified; | |||
| private final List<Integer> completedParts; | |||
There was a problem hiding this comment.
Is the reason for List that we may download different parts in parallel in the future?
There was a problem hiding this comment.
yes, trying to prepare for when we will do parallel write to file as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
completedPartsfield toResumableFileDownloadwith required serialization and deserialization.Motivation and Context
Needed to Multipart Pause/Resume logic. The
ResumableFileDownloadcan be serialized to json and deserialized back into memory to resume a download for it.Modifications
ResumableFileDownload+ BuilderTransferManagerJsonUnmarshallerfor list of IntegercompletedPartslistTesting
Added unit tests