Pause and resume for multipart download #5258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed execution attribute
…ete (do not throw exception)
L-Applin
changed the title
davidh44
reviewed
Jun 5, 2024
...ager/src/main/java/software/amazon/awssdk/transfer/s3/internal/GenericS3TransferManager.java
Show resolved
Hide resolved
...va/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloadResumeContext.java
Outdated
Show resolved
Hide resolved
...va/software/amazon/awssdk/services/s3/internal/multipart/MultipartDownloadResumeContext.java
Show resolved
Hide resolved
...ager/src/main/java/software/amazon/awssdk/transfer/s3/internal/GenericS3TransferManager.java
Outdated
Show resolved
Hide resolved
.../amazon/awssdk/transfer/s3/S3TransferManagerMultipartDownloadPauseResumeIntegrationTest.java
Outdated
Show resolved
Hide resolved
…aptor assertion to integ test.
…bute added by transfer-manager
…bute added by transfer-manager
davidh44
approved these changes
Jun 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement transfer-manager pause and resume feature for multipart download. Multipart download to file with the java-based client will be resumed from after the last completed part.
Motivation and Context
Previously, when resuming any download to file, a GetObject with the Range parameter was performed to s3, resulting in the remaining content of the object being downloaded as one bog chunk, bypassing multipart operations.
Modifications
Add a new
MultipartDownloadResumeContext, bound the the original GetRequest through a new multipart execution attribute. This context instance is updated during multipart download and can be access upon resuming.Testing
Unit test
Integ test
Manual validation