You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout triggered termination of the connection stream, causes SDK to not perform retries even if configured.
Modifications
Users of DynamoDB experienced and reported that API timeouts causing UncheckedIOException do not get retried, despite the client being configured to retry timeout exceptions.
Testing
Added unit test
Screenshots (if appropriate)
Types of changes
[ x ] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Could you please mention some details like which service was facing this issue and how this issue surfaced ?
In this particular case who exactly was throwing UncheckedIOException ?
Also please add changelogs
Yes, as discussed offline yesterday, we need to cut a broader task to identify and handle UncheckedIOExceptions throughout the SDK codebase. Now that we know it most certainly has to be retried. This SIM addresses the imminent task, which is timeout caused UncheckedIOExceptions.
Can we please update the title and change log to reflect that these changes modify the handling of exceptions when closing the response stream during an SDKInterrupted exception, changing it to just log the cause of failure.
If possible, can we write a functional test or at least perform a one-off test to ensure this addresses the issue.
Can we please also update the fix for ApiCallAttemptTimeoutTrackingStage since the reported stack trace showed this class.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Timeout triggered termination of the connection stream, causes SDK to not perform retries even if configured.
Modifications
Users of DynamoDB experienced and reported that API timeouts causing UncheckedIOException do not get retried, despite the client being configured to retry timeout exceptions.
Testing
Added unit test
Screenshots (if appropriate)
Types of changes