Skip to content

Fix V1GetterToV2 to not change get method #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ public static boolean isSetter(String name) {
}

public static boolean isGetter(String name) {
return !StringUtils.isBlank(name) && name.startsWith("get");
return !StringUtils.isBlank(name) && name.startsWith("get") && !name.equals("get");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,20 @@ public void removeSet_empty_returnsValue() {
public void removeWith_empty_returnsValue() {
assertThat(NamingUtils.removeWith("")).isEqualTo("");
}

@Test
public void isGetter_startsWithGetter_returnsTrue() {
assertThat(NamingUtils.isGetter("getFoo")).isTrue();
}

@Test
public void isGetter_equalsToGet_returnsFalse() {
assertThat(NamingUtils.isGetter("get")).isFalse();
}

@Test
public void isGetter_emptyOrNull_returnsFalse() {
assertThat(NamingUtils.isGetter("")).isFalse();
assertThat(NamingUtils.isGetter(null)).isFalse();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ void v1ModelClassGetter_isRewrittenToFluent() {
+ " ReceiveMessageRequest request = new ReceiveMessageRequest().withQueueUrl(\"url\");\n"
+ " ReceiveMessageResult receiveMessage = sqs.receiveMessage(request);\n"
+ " List<Message> messages = receiveMessage.getMessages();\n"
+ " Message message = receiveMessage.getMessages().get(0);\n"
+ " }\n"
+ "}\n",
"import software.amazon.awssdk.services.sqs.SqsClient;\n"
Expand All @@ -50,6 +51,7 @@ void v1ModelClassGetter_isRewrittenToFluent() {
+ " ReceiveMessageRequest request = ReceiveMessageRequest.builder().queueUrl(\"url\").build();\n"
+ " ReceiveMessageResponse receiveMessage = sqs.receiveMessage(request);\n"
+ " List<Message> messages = receiveMessage.messages();\n"
+ " Message message = receiveMessage.messages().get(0);\n"
+ " }\n"
+ "}"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,21 @@ public static void main(String... args) {
.nextToken("token").build();

try {

ListQueuesResponse listQueuesResult = sqs.listQueues(request);
String queueUrl = listQueuesResult.queueUrls().get(0);
String token = listQueuesResult.nextToken();
System.out.println(listQueuesResult);
System.out.println(queueUrl);
System.out.println(token);

} catch (QueueDoesNotExistException exception) {

String errorCode = exception.awsErrorDetails().errorCode();
String errorMessage = exception.awsErrorDetails().errorMessage();
String requestId = exception.requestId();
byte[] rawResponse = exception.awsErrorDetails().rawResponse().asByteArray();
System.out.println(String.format("Error code: %s, message: %s, requestId: %s", errorCode, errorMessage, requestId));

} catch (SqsException exception) {
System.out.println(String.format("Error code: %s. RequestId: %s. Raw response content: %s",
exception.awsErrorDetails().errorCode(), exception.requestId(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,21 @@ public static void main(String... args) {
.withNextToken("token");

try {

ListQueuesResult listQueuesResult = sqs.listQueues(request);
String queueUrl = listQueuesResult.getQueueUrls().get(0);
String token = listQueuesResult.getNextToken();
System.out.println(listQueuesResult);
System.out.println(queueUrl);
System.out.println(token);

} catch (QueueDoesNotExistException exception) {

String errorCode = exception.getErrorCode();
String errorMessage = exception.getErrorMessage();
String requestId = exception.getRequestId();
byte[] rawResponse = exception.getRawResponse();
System.out.println(String.format("Error code: %s, message: %s, requestId: %s", errorCode, errorMessage, requestId));

} catch (AmazonSQSException exception) {
System.out.println(String.format("Error code: %s. RequestId: %s. Raw response content: %s",
exception.getErrorCode(), exception.getRequestId(),
Expand Down
Loading