Skip to content

Prevent multipart download from hanging #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

L-Applin
Copy link
Contributor

@L-Applin L-Applin commented Aug 6, 2024

On single part download, s3 multipart client could hang and never terminates. This is the fix for that issue.

The culprit was the call to logMulitpartComplete(), when calling this method inside a synchronized block, the call to log.debug() within it would hang. The exact reason for the debug log call method to block is still uncertain.

To prevent this issue, the synchronized block was remove as it was redundant. The call to cancel() is already synchronized in the publisher the multipart Subscriber subscribes to, and the call to request() already enforce mutual exclusion in the publisher through atomic booleans.

@L-Applin L-Applin requested a review from a team as a code owner August 6, 2024 13:52
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
72.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@L-Applin L-Applin merged commit d2c1b92 into feature/master/s3mpu Aug 8, 2024
14 of 17 checks passed
@L-Applin L-Applin deleted the olapplin/multi-fix-attempt branch January 16, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants