Prevent multipart download from hanging #5466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On single part download, s3 multipart client could hang and never terminates. This is the fix for that issue.
The culprit was the call to
logMulitpartComplete()
, when calling this method inside a synchronized block, the call tolog.debug()
within it would hang. The exact reason for the debug log call method to block is still uncertain.To prevent this issue, the synchronized block was remove as it was redundant. The call to
cancel()
is already synchronized in the publisher the multipart Subscriber subscribes to, and the call torequest()
already enforce mutual exclusion in the publisher through atomic booleans.