Skip to content

Add customization in S3 to keep expires as timestamp type #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 18, 2024

Motivation and Context

Add customization in S3 to keep expires as timestamp type

Modifications

  • Update ShapeSubstitutionsProcessor to handle emitAsType
  • Add customization in S3 to keep expires as timestamp type

Testing

  • Added unit tests
  • Changed expires to string type in s3 and verified with japicmp that no breaking changes are introduced.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner September 18, 2024 22:53
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

if (emitAsType != null) {
Shape newShapeForType = new Shape();
newShapeForType.setType(emitAsType);
String shapeName = "SdkCustomization_" + emitAsType;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, what is this SdkCustomization_ name prefix for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the case where we need to add a new type to the service model. In this case, we are adding "SdkCustomization_ expires": {"type": "timestamp"} to S3 since it doesn't have a generic timestamp type.

@zoewangg zoewangg added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit f1e0f55 Sep 20, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants