Cleanup pending task comments #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
varunnvs92
commented
Jun 22, 2018
varunnvs92
commented
- Remove fixed TODOs, ReviewBeforeRelease annotations
- Clean up comments to remove words like "hacky"
varunnvs92
force-pushed
the
varunkn/CleanupTodos
branch
from
a36cdbf to
a8b58ab
Compare
zoewangg
approved these changes
Jun 25, 2018
| @@ -124,8 +124,6 @@ protected final ShapeModel generateShapeModel(String javaClassName, String shape | |||
| final List<String> enumValues = shape.getEnumValues(); | |||
| if (enumValues != null && !enumValues.isEmpty()) { | |||
| for (String enumValue : enumValues) { | |||
| // TODO handle useRealName if explicitly mentioned in | |||
There was a problem hiding this comment.
did we already finish this todo?
There was a problem hiding this comment.
This TODO is from v1 which was added 3 years back. I think we never prioritized it. So removed it as its not specific to v2 and not a blocker for GA.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 25, 2019
…ac384b39 Pull request: release <- staging/5169e5d5-6f42-4acb-bd5f-e838ac384b39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.