Skip to content

Allow default values for non-builtIn endpoint params #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

Allow default values for non-builtIn endpoint params #6084

merged 1 commit into from
May 2, 2025

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented May 2, 2025

Motivation and Context

Modifications

Remove restriction, to allow default values to be set for non builtIn endpoint parameters

Testing

Compiled codegen and codegen-generated-classes-test locally

@davidh44 davidh44 requested a review from a team as a code owner May 2, 2025 21:15
@davidh44 davidh44 enabled auto-merge May 2, 2025 21:40
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@davidh44 davidh44 added this pull request to the merge queue May 2, 2025
Merged via the queue into master with commit 39d95ee May 2, 2025
22 checks passed
@davidh44 davidh44 deleted the hdavidh/endpoint-rule-param-allow-default-values branch May 2, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidh44 @dagnir