Skip to content

Add @Mutable and @NotThreadSafe to model Builders #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

alextwoods
Copy link
Contributor

Add @Mutable and @NotThreadSafe to model Builders (including Request Builders)

Motivation and Context

Fixes: #6007

This PR adds the @Mutable and @NotThreadSafe annotations to model Builders to improve documentation and mark them as not thread safe and discourage usage in non-thread safe contexts.

Modifications

  • Add @Mutable and @NotThreadSafe to model Builders (including Request Builders)

Testing

Updated existing codegen test generated files - see diff.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner May 9, 2025 19:06
Copy link

sonarqubecloud bot commented May 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
55.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@alextwoods alextwoods added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit aabd35e May 12, 2025
28 of 30 checks passed
@alextwoods alextwoods deleted the alexwoo/mutable_annotation_request_builders branch May 13, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent issue where S3 upload appears successful (200 OK) but object is missing
3 participants