Skip to content

Migration tool recipe for adding comments for unsupported methods #6195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 20, 2025

Conversation

Fred1155
Copy link
Contributor

Motivation and Context

Added support for some additional pojo methods and client method
Added comment recipe for client method

Modifications

Added recipe for uploadDirectory method
Added recipe to add comments for copy, upload, download, uploadDirectory, downloadDirectory method
Added recipe to add comments for client constructor.

Testing

Added integration test cases
Tested locally for noncompliable method

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner June 19, 2025 18:04
@Fred1155 Fred1155 added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jun 19, 2025
@Fred1155 Fred1155 enabled auto-merge June 19, 2025 22:25
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Fred1155 Fred1155 added this pull request to the merge queue Jun 19, 2025
Merged via the queue into master with commit a6be409 Jun 20, 2025
27 of 28 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2025
@Fred1155 Fred1155 deleted the bole/s3_tm_pojo_methods branch June 20, 2025 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants