Fixing bug where more events than requested could be delivered. #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Update the codegen tests |
varunnvs92
approved these changes
Aug 10, 2018
dagnir
approved these changes
Aug 10, 2018
| * from {@link #drainEventsIfNotAlready()} in that it assumes it has the {@link #isDelivering} 'lease' already. | ||
| */ | ||
| private void drainEvents() { | ||
| // If we've already delivered an exception to the subscriber than bail out |
There was a problem hiding this comment.
I think this might be misleading. isDone is set to true when the the stream completes normally as well (in onEventComplete)
There was a problem hiding this comment.
I believe it's still true as we wouldn't be draining events after onEventComplete is called. So the only scenario where isDone is true in this method is if the stream was completed exceptionally.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Oct 30, 2019
…6c1a1351 Pull request: release <- staging/6917eaf8-94fa-48c9-849d-051f6c1a1351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.