Skip to content

Attach SdkHttpResponse to the responses of event streaming opeartions #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 18, 2018

Description

Bug fix. SdkHttpResponse is missing from the response of event streaming operations.
Created AttachHttpMetadataResponseHandler as a decorator to set the SdkHttpResponse.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from shorea September 18, 2018 20:27
@zoewangg zoewangg force-pushed the zoewang-attachSdkHttpResponseToEventStream branch from ce75212 to c82a818 Compare September 19, 2018 00:22
@zoewangg zoewangg merged commit a3998eb into master Sep 19, 2018
@zoewangg zoewangg deleted the zoewang-attachSdkHttpResponseToEventStream branch September 19, 2018 00:49
aws-sdk-java-automation pushed a commit that referenced this pull request Jan 7, 2020
Updating to latest Node runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants