Add OSGi Bundle metadata #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache Aries SPI Fly is used to provide runtime loading of HTTP clients. Fixes aws#607
varunnvs92
reviewed
Sep 24, 2018
|
|
||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> |
There was a problem hiding this comment.
why is this plugin required in modules like flow, services. Isn't just http-clients and core enough?
There was a problem hiding this comment.
I'm not sure what you mean. All of the dependencies pulled in by a service client need to be OSGi compatible, which includes flow.
varunnvs92
approved these changes
Sep 24, 2018
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 4, 2020
…29d6e7ea Pull request: release <- staging/8bb6144f-3114-42ce-83b0-12b229d6e7ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add OSGi metadata to MANIFEST.MF
Note: This does not completely enable the SDK to be loaded in an OSGi container because of some currently blockers. See #719 and #726.
Motivation and Context
Step towards allowing SDK to be used in OSGi.
Testing
mvn clean installand check JAR MANIFEST.MF files.Tested a modified version of this PR that exports all packages (including
.internal.packages) by loading the required bundles for ACM in Apache Felix and made a service call.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense