Skip to content

Remove TODO which is fixed through RestEventStreamAsyncResponseTransf… #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Remove TODO which is fixed through RestEventStreamAsyncResponseTransf… #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .../java/software/amazon/awssdk/awscore/eventstream/EventStreamAsyncResponseTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ public CompletableFuture<Void> prepare() {

@Override
public void onResponse(SdkResponse response) {
// We use a void unmarshaller and unmarshall the actual response in the message
// decoder when we receive the initial-response frame. TODO not clear
// how we would handle REST protocol which would unmarshall the response from the HTTP headers
if (response != null && response.sdkHttpResponse() != null) {
this.requestId = response.sdkHttpResponse()
.firstMatchingHeader(X_AMZN_REQUEST_ID_HEADER)
Expand Down