Moving USER_AGENT_SUFFIX value to the end of the user agent #801
Conversation
varunnvs92
force-pushed
the
FixUserAgentSuffix
branch
from
cdbb4b5 to
4d2474e
Compare
| @@ -83,6 +79,11 @@ private String getUserAgent(SdkClientConfiguration config, List<ApiName> request | |||
| userAgent.append(SPACE).append(requestUserAgent); | |||
| } | |||
|
|
|||
| // Note: This should be at the end of user agent | |||
There was a problem hiding this comment.
Can we move it to a method, something like appendUserDefinedSuffix? Can we also add a test for it (rather than relying on the note)?
There was a problem hiding this comment.
I moved it to a different method. I can't think of a test that can catch these issues reliably. If we decide to include new config options in user agent, any test we write now can't take the future variables into account.
There was a problem hiding this comment.
The other option is to create an new ApplyUserAgentSuffixStage. I prefer to keep all user agent related changes in single class. But I am okay with splitting too if we decide so.
There was a problem hiding this comment.
A new ApplyUserAgentSuffixStage seems a bit overkill. Keeping it as it is looks good to me.
varunnvs92
force-pushed
the
FixUserAgentSuffix
branch
from
4d2474e to
82bf980
Compare
varunnvs92
force-pushed
the
FixUserAgentSuffix
branch
from
82bf980 to
dbf3ea7
Compare
…1bc0e407 Pull request: release <- staging/73d90b43-0cdd-4821-9e27-23151bc0e407
No description provided.