Fix race condition in FileAsyncResponseTransformer #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunnvs92
force-pushed
the
FileAsyncResponseTransformerFix
branch
from
48c390c to
a5ce1ff
Compare
shorea
reviewed
Nov 15, 2018
| } | ||
|
|
||
| private void close() { | ||
| if (fileChannel != null) { | ||
| invokeSafely(fileChannel::close); | ||
| } | ||
| future.complete(null); |
There was a problem hiding this comment.
if the file channel fails to close should we complete the future exceptionally?
…e completed before last bytebuffer is written to the file
varunnvs92
force-pushed
the
FileAsyncResponseTransformerFix
branch
from
a5ce1ff to
15681db
Compare
shorea
approved these changes
Nov 16, 2018
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 4, 2020
…9a1b1712 Pull request: release <- staging/77687b6f-1aea-41e5-8d4d-bdfd9a1b1712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition in FileAsyncResponseTransformer where future can be completed before last bytebuffer is written to the file