Skip to content

define a version for jackson annotations to match jackson's depend… #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

tomliu4uber
Copy link
Contributor

…ency

definition an new version variable that matches fasterxml-jackson's own definition

Description

  • define a new variable for jackson.annotations (jackson 2.9.7 uses annotation version 2.9.0)
  • use the variable in dependency management for jackson.annotations

Motivation and Context

#948

Testing

recompile the whole project and make sure all unit tests pass

Screenshots (if appropriate)

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [X ] I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • [X ] My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • [ X] I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • [X ] A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [X ] I confirm that this pull request can be released under the Apache 2 license

@tomliu4uber tomliu4uber changed the title defintion a version for jackson annotations to match jackson's depend… define a version for jackson annotations to match jackson's depend… Dec 21, 2018
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Thank you for your contribution!

@zoewangg zoewangg merged commit 1164d1b into aws:master Dec 21, 2018
aws-sdk-java-automation added a commit that referenced this pull request Sep 25, 2020
…a956f97c

Pull request: release <- staging/ed80798b-5227-43b7-9603-bf0ca956f97c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants