update dependency versions #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an explicit update to versions. Additionally all sub modules package-lock.json files are removed. When lerna link was run, in aws#27 all modules were linked together at the root. This means that the root package-lock.json file is responsible for all sub modules state. Lerna does not maintain the state on these modules package-lock.json anymore. So this information is redundant. This is similar to aws/aws-encryption-sdk-javascript#285
scottarc
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an explicit update to versions.
Additionally all sub modules package-lock.json files are removed.
When lerna link was run, in #27
all modules were linked together at the root.
This means that the root package-lock.json file is responsible
for all sub modules state.
Lerna does not maintain the state on these modules package-lock.json anymore.
So this information is redundant.
This is similar to
aws/aws-encryption-sdk-javascript#285
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.