Skip to content

fix(uint32ArrayFrom): increment index & polyfill for Uint32Array #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2021
Merged

fix(uint32ArrayFrom): increment index & polyfill for Uint32Array #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
981cf82
fix(uint32ArrayFrom): increment index and polyfill for Uint32Array in…
texastony Nov 29, 2021
0b327a2
test(uint32ArrayFrom): test Uint32ArrayFrom
texastony Nov 29, 2021
5546d7a
style(uint32ArrayFromTest): remove blank spaces
texastony Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/util/src/uint32ArrayFrom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@

// IE 11 does not support Array.from, so we do it manually
export function uint32ArrayFrom(a_lookUpTable: Array<number>): Uint32Array {
if (!Array.from) {
if (!Uint32Array.from) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need this for other types (Uint8Array.from) in the future?

const return_array = new Uint32Array(a_lookUpTable.length)
let a_index = 0
while (a_index < a_lookUpTable.length) {
return_array[a_index] = a_lookUpTable[a_index]
a_index += 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks like the correct fix

}
return return_array
}
Expand Down
20 changes: 20 additions & 0 deletions packages/util/test/uint32ArrayFrom.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import { expect } from "chai";
import "mocha";
import { uint32ArrayFrom } from "../src/uint32ArrayFrom";

describe("uint32ArrayFrom", () =>{
it("When given an empty array, should return an empty array", () => {
expect(uint32ArrayFrom(Array.of(0)))
.to
.eql(Uint32Array.of(0))
})

it("Given a populated array, returns a valid Uint32 Array", () => {
expect(uint32ArrayFrom(Array.of(0x00000000, 0xF26B8303, 0xE13B70F7)))
.to
.eql(Uint32Array.of(0, 4067132163, 3778769143))
})
})