Skip to content

chore(deps-dev): update verdaccio #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

josecorella
Copy link
Contributor

@josecorella josecorella commented Mar 23, 2022

Issue #, if available:

Updates verdaccio dependency to deal with dependabot notice.

Description of changes:

  • updated verdaccio from ^5.1.6 to ^5.8.0
  • ran the following commands:
    • npm audit fix
    • npm install verdaccio
    • npm dedupe
    • npm update verdaccio
    • npm run verdaccio-publish
    • npm run verdaccio-verfiy-publish --ci

The following lines show that the audit worked (make sure to click on load diff )

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josecorella josecorella marked this pull request as ready for review March 23, 2022 18:42
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: In particular, I see that marked, json-schema, and validator have all been upgraded in the package-lock to versions that Dependabot says are safe.

@josecorella
Copy link
Contributor Author

LGTM: In particular, I see that marked, json-schema, and validator have all been upgraded in the package-lock to versions that Dependabot says are safe.

yup! they get picked up from verdaccio so we killed three birds with one stone

@josecorella josecorella merged commit ebc45ab into aws:master Mar 23, 2022
@josecorella josecorella deleted the update_verdaccio branch March 23, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants