Skip to content

feat!: deprecate node12. BREAKING CHANGE: Remove node12 from CI #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

Remove CI testing under Node 12

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner February 17, 2023 22:30
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we merge this in, let's change the pr title so it conforms to
conventional commits and it is able to pick up the new version.
you can look at an example here: 723e6d2

@ajewellamz ajewellamz changed the title feat: remove testing under Node 12 feat: updates support policy for node 12 Feb 17, 2023
@ajewellamz ajewellamz changed the title feat: updates support policy for node 12 feat!: deprecate node12 BREAKING CHANGE: Remove node12 from CI Feb 17, 2023
@ajewellamz ajewellamz changed the title feat!: deprecate node12 BREAKING CHANGE: Remove node12 from CI feat!: deprecate node12\nBREAKING CHANGE: Remove node12 from CI Feb 17, 2023
@ajewellamz ajewellamz changed the title feat!: deprecate node12\nBREAKING CHANGE: Remove node12 from CI feat!: deprecate node12. BREAKING CHANGE: Remove node12 from CI Feb 17, 2023
@ajewellamz ajewellamz merged commit d85ca33 into master Feb 20, 2023
@ajewellamz ajewellamz deleted the deprecate-12 branch February 20, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants