chore: rename 'connection' to 'session'

Author: trivikr

packages/node-http-handler/src/node-http2-handler.spec.ts

@@ -48,11 +48,11 @@ describe(NodeHttp2Handler.name, () => {
 
     afterEach(() => {
       // @ts-ignore: access private property
-      const connectionPool = nodeH2Handler.connectionPool;
-      for (const [, session] of connectionPool) {
+      const sessionPool = nodeH2Handler.sessionPool;
+      for (const [, session] of sessionPool) {
         session.destroy();
       }
-      connectionPool.clear();
+      sessionPool.clear();
     });
 
     it("has metadata", () => {
@@ -219,30 +219,30 @@ describe(NodeHttp2Handler.name, () => {
     });
 
     describe("destroy", () => {
-      it("destroys session and clears connectionPool", async () => {
+      it("destroys session and clears sessionPool", async () => {
         await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
 
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+        const session: ClientHttp2Session = nodeH2Handler.sessions[0];
 
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connectionPool.size).toBe(1);
+        expect(nodeH2Handler.sessionPool.size).toBe(1);
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connections.length).toBe(1);
+        expect(nodeH2Handler.sessions.length).toBe(1);
         expect(session.destroyed).toBe(false);
         nodeH2Handler.destroy();
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connectionPool.size).toBe(0);
+        expect(nodeH2Handler.sessionPool.size).toBe(0);
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connections.length).toBe(0);
+        expect(nodeH2Handler.sessions.length).toBe(0);
         expect(session.destroyed).toBe(true);
       });
     });
 
     describe("abortSignal", () => {
       it("will not create session if request already aborted", async () => {
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connectionPool.size).toBe(0);
+        expect(nodeH2Handler.sessionPool.size).toBe(0);
         await expect(
           nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {
             abortSignal: {
@@ -252,15 +252,15 @@ describe(NodeHttp2Handler.name, () => {
           })
         ).rejects.toHaveProperty("name", "AbortError");
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connectionPool.size).toBe(0);
+        expect(nodeH2Handler.sessionPool.size).toBe(0);
       });
 
       it("will not create request on session if request already aborted", async () => {
         // Create a session by sending a request.
         await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
 
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+        const session: ClientHttp2Session = nodeH2Handler.sessions[0];
         const requestSpy = jest.spyOn(session, "request");
 
         await expect(
@@ -347,15 +347,15 @@ describe(NodeHttp2Handler.name, () => {
 
         const authority = `${protocol}//${hostname}:${port}`;
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+        const session: ClientHttp2Session = nodeH2Handler.sessions[0];
         expect(session.closed).toBe(false);
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connectionPool.get(authority)).toBeDefined();
+        expect(nodeH2Handler.sessionPool.get(authority)).toBeDefined();
         setTimeout(() => {
           expect(session.closed).toBe(true);
           expect(session.destroyed).toBe(false);
           // @ts-ignore: access private property
-          expect(nodeH2Handler.connectionPool.get(authority)).not.toBeDefined();
+          expect(nodeH2Handler.sessionPool.get(authority)).not.toBeDefined();
           done();
         }, sessionTimeout + 100);
       });
@@ -365,7 +365,7 @@ describe(NodeHttp2Handler.name, () => {
         await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
 
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+        const session: ClientHttp2Session = nodeH2Handler.sessions[0];
         expect(session.closed).toBe(false);
         setTimeout(() => {
           expect(session.closed).toBe(true);
@@ -439,14 +439,14 @@ describe(NodeHttp2Handler.name, () => {
         await nodeH2Handler.handle(new HttpRequest(getMockReqOptions()), {});
 
         // @ts-ignore: access private property
-        const session: ClientHttp2Session = nodeH2Handler.connections[0];
+        const session: ClientHttp2Session = nodeH2Handler.sessions[0];
 
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connections.length).toBe(1);
+        expect(nodeH2Handler.sessions.length).toBe(1);
         expect(session.destroyed).toBe(false);
         nodeH2Handler.destroy();
         // @ts-ignore: access private property
-        expect(nodeH2Handler.connections.length).toBe(0);
+        expect(nodeH2Handler.sessions.length).toBe(0);
         expect(session.destroyed).toBe(true);
       });
     });

packages/node-http-handler/src/node-http2-handler.ts

@@ -38,20 +38,20 @@ export class NodeHttp2Handler implements HttpHandler {
   private readonly disableSessionCache?: boolean;
 
   public readonly metadata = { handlerProtocol: "h2" };
-  private connections: ClientHttp2Session[];
-  private connectionPool: Map<string, ClientHttp2Session>;
+  private sessions: ClientHttp2Session[];
+  private sessionPool: Map<string, ClientHttp2Session>;
 
   constructor({ requestTimeout, sessionTimeout, disableSessionCache }: NodeHttp2HandlerOptions = {}) {
     this.requestTimeout = requestTimeout;
     this.sessionTimeout = sessionTimeout;
     this.disableSessionCache = disableSessionCache;
-    this.connections = [];
-    this.connectionPool = new Map<string, ClientHttp2Session>();
+    this.sessions = [];
+    this.sessionPool = new Map<string, ClientHttp2Session>();
   }
 
   destroy(): void {
-    this.connections.forEach((session) => this.destroySession(session));
-    this.connectionPool.clear();
+    this.sessions.forEach((session) => this.destroySession(session));
+    this.sessionPool.clear();
   }
 
   handle(request: HttpRequest, { abortSignal }: HttpHandlerOptions = {}): Promise<{ response: HttpResponse }> {
@@ -157,7 +157,7 @@ export class NodeHttp2Handler implements HttpHandler {
       });
     }
 
-    this.connections.push(newSession);
+    this.sessions.push(newSession);
     return newSession;
   }
 
@@ -167,7 +167,7 @@ export class NodeHttp2Handler implements HttpHandler {
    * @returns A session for the given URL.
    */
   private getSessionFromPool(authority: string): ClientHttp2Session {
-    const connectionPool = this.connectionPool;
+    const connectionPool = this.sessionPool;
     const existingSession = connectionPool.get(authority);
     if (existingSession) return existingSession;
 
@@ -199,7 +199,7 @@ export class NodeHttp2Handler implements HttpHandler {
     if (!session.destroyed) {
       session.destroy();
     }
-    this.connections = this.connections.filter((s) => s !== session);
+    this.sessions = this.sessions.filter((s) => s !== session);
   }
 
   /**
@@ -208,10 +208,10 @@ export class NodeHttp2Handler implements HttpHandler {
    * @param session The session to delete.
    */
   private deleteSessionFromPool(authority: string, session: ClientHttp2Session): void {
-    if (this.connectionPool.get(authority) !== session) {
+    if (this.sessionPool.get(authority) !== session) {
       // If the session is not in the pool, it has already been deleted.
       return;
     }
-    this.connectionPool.delete(authority);
+    this.sessionPool.delete(authority);
   }
 }